Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yadocs fixes #88

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Yadocs fixes #88

merged 2 commits into from
Nov 10, 2023

Conversation

vallbull
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Test Results

269 tests   219 ✔️  11m 53s ⏱️
    7 suites    50 💤
    7 files        0 ❌

Results for commit 17322c1.

KonstantAnxiety
KonstantAnxiety reviewed Nov 10, 2023
View reviewed changes
lib/dl_file_uploader_api_lib/dl_file_uploader_api_lib/schemas/files.py
Comment on lines +29 to +30
if data["private_path"] is None:
raise ma.ValidationError("'private_path' must be provided for private files")
Copy link
Contributor

@KonstantAnxiety KonstantAnxiety Nov 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is unreachable
This case is covered by the very first condition (not (A ^ B))

@vallbull vallbull merged commit f54100d into main Nov 10, 2023
11 of 12 checks passed
@vallbull vallbull deleted the yadocs_fixes branch November 10, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonstantAnxiety KonstantAnxiety KonstantAnxiety approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vallbull @KonstantAnxiety